Skip to content

Fix compile issue with missing/needed <endian.h> includes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix compile issue with missing/needed <endian.h> includes #25

wants to merge 1 commit into from

Conversation

skilau
Copy link

@skilau skilau commented Feb 14, 2025 •
edited by MathisMARION
Loading

Without adding in the include of <endian.h> in 2 files that use functions/defines from it, we end up getting compiler errors and linking errors.
(Specifically, the htobe16 and be64toh functions/defines, which exist in <endian.h>)

Including the compile log below, just to show the errors that we get:

[22/132] Building C object CMakeFiles/libwsbrd.dir/common/crypto/ieee80211.c.o
common/crypto/ieee80211.c: In function ‘ieee80211_is_mic_valid’:
common/crypto/ieee80211.c:39:31: warning: implicit declaration of function ‘htobe16’ [-Wimplicit-function-declaration]
   39 |         .packet_body_length = htobe16(sizeof(*frame) + data_len),
      |                               ^~~~~~~

[57/132] Building C object CMakeFiles/libwsbrd.dir/common/ieee802154_frame.c.o
common/ieee802154_frame.c: In function ‘ieee802154_frame_parse’:
common/ieee802154_frame.c:204:25: warning: implicit declaration of function ‘htobe64’ [-Wimplicit-function-declaration]
  204 |         hdr->dst.be64 = htobe64(iobuf_pop_le64(&iobuf));
      |                         ^~~~~~~

common/ieee802154_frame.c: In function ‘ieee802154_frame_write_hdr’:
common/ieee802154_frame.c:274:32: warning: implicit declaration of function ‘be64toh’ [-Wimplicit-function-declaration]
  274 |         iobuf_push_le64(iobuf, be64toh(hdr->dst.be64));
      |                                ^~~~~~~

Fix compile issue with missing/needed <endian.h> includes
78015fb 
Without adding in the include of <endian.h> in 2 files that
use functions/defines from it, we end up getting compiler errors
and linking errors.
@MathisMARION
Copy link
Collaborator

Applied onto our private development branch, thank you very much for your contribution! This should be released in version 2.3.1.

MathisMARION pushed a commit that referenced this pull request Mar 5, 2025
@MathisMARION
build: fix compile issue with missing/needed <endian.h> includes
5d413f2 
Without adding in the include of <endian.h> in 2 files that
use functions/defines from it, we end up getting compiler errors
and linking errors.

Origin: #25
MathisMARION pushed a commit that referenced this pull request Apr 4, 2025
@MathisMARION
build: fix compile issue with missing/needed <endian.h> includes
e31fc5c 
Without adding in the include of <endian.h> in 2 files that
use functions/defines from it, we end up getting compiler errors
and linking errors.

Origin: #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathisMARION MathisMARION MathisMARION approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skilau @MathisMARION